[blog] Introducing callback support in style overrides #30668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
reviewed
Jan 17, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
danilo-leal
approved these changes
Jan 19, 2022
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
danilo-leal
reviewed
Jan 20, 2022
1 task
Co-authored-by: danilo leal <67129314+danilo-leal@users.noreply.github.com>
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
mbrookes
requested changes
Jan 25, 2022
| </Box>; | ||
| ``` | ||
|
|
||
| > 💡 All MUI components are created with `styled` API, so they accept `sx` prop by default. |
There was a problem hiding this comment.
Suggested change
| > 💡 All MUI components are created with `styled` API, so they accept `sx` prop by default. | |
| > 💡 All MUI components are created with the `styled` API, so they accept `sx` prop by default. |
|
|
||
| > 💡 All MUI components are created with `styled` API, so they accept `sx` prop by default. | ||
|
|
||
| `sx` helps developers write less code and be more productive once they are familiar with the API. With the callback support in `styleOverrides`, it is now possible to use `sx` like syntax at the global theme overrides. |
There was a problem hiding this comment.
Suggested change
| `sx` helps developers write less code and be more productive once they are familiar with the API. With the callback support in `styleOverrides`, it is now possible to use `sx` like syntax at the global theme overrides. | |
| `sx` helps developers write less code and be more productive once they are familiar with the API. With the callback support in `styleOverrides`, it is now possible to use an `sx`-like syntax in global theme overrides. |
| </ThemeProvider>; | ||
| ``` | ||
|
|
||
| If you want to create a dynamic style based on props, you can return an array from the callback: |
There was a problem hiding this comment.
Perhaps explain the example? Either: "In the following example" or with inline comments (or both). Also consider if other examples would benefit from further explanation.
Co-authored-by: Matt <github@nospam.33m.co>
mnajdova
approved these changes
Jan 26, 2022
oliviertassinari
changed the title
v5.3 announcement
oliviertassinari
approved these changes
Jan 26, 2022
| --- | ||
| title: Introducing callback support in style overrides | ||
| description: We're excited to introduce callback support for global theme overrides in this minor version update! | ||
| date: 2022-01-20T00:00:00.000Z |
There was a problem hiding this comment.
Are we good with the date? Do we want to use the release date of v5.3.0 or the blog post publish date?
There was a problem hiding this comment.
Yep, I will mark the next Monday as the blog post released date.
| ...(ownerState.variant === 'outlined' && { | ||
| borderWidth: '2px', | ||
| ...(ownerState.variant === 'primary' && { | ||
| borderColor: theme.palette.primary.light, |
There was a problem hiding this comment.
I don't think that there is any risk for circular references.
| </ThemeProvider>; | ||
| ``` | ||
|
|
||
| > 💡 The side benefit of using a callback is that you can use the runtime theme without creating the outer scoped variable. |
There was a problem hiding this comment.
I think it is just a side benefit which is not the main purpose.
We have multiple threads where developers complain about this. But from what I remember, it was a step before. The main pain is for building the core set of design tokens, not so much for the customization of components.
siriwatknp
commented
Jan 27, 2022
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
wladimirguerra
pushed a commit
to wladimirguerra/material-ui
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Preview site: https://deploy-preview-30668--material-ui.netlify.app/blog/callback-support-in-style-overrides/
This PR should be merged after #30121toggle ON the blog index page (@danilo-leal I forgot to do this in the previous PR 🥲)Once this PR is merged, will deploy the docs manually.