Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ButtonBase] Fix cannot read properties of null (reading 'pulsate') for react@18 & material-ui/core@4 #32395

Closed
wants to merge 1 commit into from

Conversation

perevezencev
Copy link

@perevezencev perevezencev commented Apr 20, 2022

Fixes #30953

@danilo-leal danilo-leal added the component: ButtonBase The React component. label Apr 20, 2022
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not guarantee that v4 supports React 18, it is not in it's peer dependencies. There are more issues than this one for sure. Please consider upgrading to v5 instead.

@mnajdova mnajdova added the v4.x label Apr 28, 2022
@mnajdova
Copy link
Member

Looks like the fix was already applied in v5, so I am closing the pull request. Thanks for spending time on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ButtonBase The React component. v4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants