-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fix CodeSandbox & StackBlitz generation #32726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
May 17, 2022
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
May 20, 2022
mnajdova
reviewed
May 20, 2022
mnajdova
reviewed
May 20, 2022
mnajdova
reviewed
May 20, 2022
mnajdova
reviewed
May 20, 2022
mnajdova
reviewed
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, I've left few comments. Let's also address Olivier's feedback.
All fixed! |
mnajdova
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-32726--material-ui.netlify.app/material-ui/react-button/#basic-button
Issues
[BUG] StackBlitz does not work on the production. Also, theThis bug is gone indemo.tsx
does not show on the editor. Proof: https://mui.com/material-ui/react-button/v5.8.0
because we have moved the private classnames to mui-utilsRefactoring
Here is how it worked before:
There is only 1 function, the
getDemoConfig()
which call other functions and so on. If we want to adjust the dependencies, we have to pass the props from the top down to the bottom. This is quite hard to adapt and write tests.Here is the refactored version:
The sandbox modules split into
CodeSandbox
andStackBlitz
to provide flexibility and composition of other APIs. Both of them contain the methodcreateReactApp
that use theCreateReactApp
module to generate templates between products.In the future, if we want to generate NextJS template, this will be very easy.
The dependencies module handles the extraction from the file and assign version based on the config.
Fix