Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Allow developers to build their CodeSandbox export #40878

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 31, 2024

This is a continuation of #32726. To make #40833 for an optimal bug reproduction experience, developers should be able to build their reproduction when they fork demos from the docs.

The current issue https://codesandbox.io/p/sandbox/intelligent-pond-fjkdsd?file=%2Fpackage.json%3A13%2C4

Screenshot 2024-01-31 at 20 16 19

Which is different from standard CRA projects, e.g.

"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
"test": "react-scripts test",
"eject": "react-scripts eject"

I saw that while I was checking something else on MUI X. Thought it was a quick win.

@oliviertassinari oliviertassinari added enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product labels Jan 31, 2024
@mui-bot
Copy link

mui-bot commented Jan 31, 2024

Netlify deploy preview

https://deploy-preview-40878--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6c58f18

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliviertassinari oliviertassinari merged commit e1231ee into mui:master Feb 1, 2024
19 checks passed
mostafa-rio pushed a commit to mostafa-rio/material-ui that referenced this pull request Feb 3, 2024
@oliviertassinari oliviertassinari deleted the codesandbox-build branch February 7, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants