-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update templates' readme files to include required dependencies #34757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
added
docs
Improvements or additions to the documentation
package: material-ui
Specific to @mui/material
labels
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a bunch of "the"s, otherwise looks good 👍
docs/data/material/getting-started/templates/checkout/README.md
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/dashboard/README.md
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sign-in-side/README.md
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/sticky-footer/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com> Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
@samuelsycamore I applied your suggestions. Could you please take one more look at this? |
samuelsycamore
approved these changes
Oct 26, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
mui#34757) Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
mui#34757) Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention the dependencies required to run the templates in each one's README.
Closes #34703