Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update templates' readme files to include required dependencies #34757

Merged
merged 2 commits into from Oct 27, 2022

Conversation

michaldudak
Copy link
Member

Mention the dependencies required to run the templates in each one's README.

Closes #34703

@michaldudak michaldudak added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Oct 14, 2022
@mui-bot
Copy link

mui-bot commented Oct 14, 2022

No bundle size changes

Generated by 🚫 dangerJS against 7177d23

Copy link
Member

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a bunch of "the"s, otherwise looks good 👍

Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Michał Dudak <michal.dudak@gmail.com>
@michaldudak
Copy link
Member Author

@samuelsycamore I applied your suggestions. Could you please take one more look at this?

@michaldudak michaldudak merged commit 3f88e94 into mui:master Oct 27, 2022
@michaldudak michaldudak deleted the templates-dependencies branch October 27, 2022 14:31
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
mui#34757)

Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
feliperli pushed a commit to jesrodri/material-ui that referenced this pull request Dec 6, 2022
mui#34757)

Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard Example shows white blank screen
3 participants