Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FormLabel] Export FormLabelOwnProps from FormLabel to fix type error #36057

Merged
merged 1 commit into from
Feb 6, 2023
Merged

[FormLabel] Export FormLabelOwnProps from FormLabel to fix type error #36057

merged 1 commit into from
Feb 6, 2023
+1 −1

Conversation

yoskeoka
Copy link
Contributor

@yoskeoka yoskeoka commented Feb 4, 2023 •
edited by ZeeshanTamboli
Loading

@mui-bot
Copy link

mui-bot commented Feb 4, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-36057--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 6e5e646

@yoskeoka
Copy link
Contributor Author

yoskeoka commented Feb 6, 2023

Can anyone add labels like 'bug' 'typescript' 'component:FormLabel' or something?
I don't have a permission to do that.

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript component: FormControl The React component labels Feb 6, 2023
ZeeshanTamboli
ZeeshanTamboli approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good!

@ZeeshanTamboli ZeeshanTamboli merged commit 8a64241 into mui:master Feb 6, 2023
@ZeeshanTamboli ZeeshanTamboli added the regression A bug, but worse label Feb 6, 2023
@yoskeoka yoskeoka deleted the 36035-export-FormLabelOwnProps branch February 6, 2023 07:55
@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Apr 18, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: FormControl The React component regression A bug, but worse typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FormLabel] Export FormLabelOwnProps from FormLabel to fix type error
3 participants
@yoskeoka @mui-bot @ZeeshanTamboli