-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve API for theme default prop #36490
[docs] Improve API for theme default prop #36490
Conversation
Netlify deploy preview
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size report |
629e5e0
to
981cccd
Compare
Follow-up thoughts:
|
(1) I opened a PR (#36519) for this today (didn't know you opened a PR for it already!). I think we can go with your PR. (3) I will handle this. (4) I think we should. I can take of this. #36540 (5) I will handle this. #36539 (6) cc @michaldudak @siriwatknp |
@oliviertassinari For example, PopperUnstyled is missing EDIT: Base components will no longer have |
9b65f37
to
6656495
Compare
6656495
to
0b531a4
Compare
For (6), I think we can extract the description and put it above the table (in a separate PR). This will also fix #36328 (comment). |
I initially only wanted to remove logic related to a given open-source project from the ApiPage so we can keep it more generic, e.g.
material-ui/docs/src/modules/components/ApiPage.js
Line 303 in f71821e
there shouldn't be project specific logic like this, it's way too specific when it can be inside the json.
But then, I went a bit above to differentiate default prop customization to style customization. These are implemented differently now, especially with the data grid.
Before:
After: