Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Ensure classname displayed under Slots section in API docs exists #36539

Merged
merged 6 commits into from
Mar 20, 2023
Merged

[docs] Ensure classname displayed under Slots section in API docs exists #36539

merged 6 commits into from
Mar 20, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Mar 16, 2023 •
edited by oliviertassinari

Follow-up on (5) of #36490 (comment)

Before
https://master--material-ui.netlify.app/base/api/slider-unstyled/#slots

After
https://deploy-preview-36539--material-ui.netlify.app/base/api/slider-unstyled/#slots

@hbjORbj hbjORbj self-assigned this Mar 16, 2023
@hbjORbj hbjORbj changed the title [docs] Ensure classname displayed under Slots section exists [docs] Ensure classname displayed under Slots section in API docs exists Mar 16, 2023
@mui-bot
Copy link

mui-bot commented Mar 16, 2023 •
edited

Netlify deploy preview

https://deploy-preview-36539--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against c72df4f

@hbjORbj hbjORbj added docs Improvements or additions to the documentation package: base-ui Specific to @mui/base package: joy-ui Specific to @mui/joy labels Mar 16, 2023
@hbjORbj hbjORbj mentioned this pull request Mar 16, 2023
Merged
@hbjORbj hbjORbj requested a review from siriwatknp March 16, 2023 18:03
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2023
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Mar 17, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 17, 2023
oliviertassinari
oliviertassinari reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first sight, this makes sense 👍

siriwatknp
siriwatknp approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 just nit from @oliviertassinari review.

@hbjORbj hbjORbj mentioned this pull request Mar 20, 2023
Merged
1 task
@hbjORbj hbjORbj merged commit 3764be1 into mui:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@siriwatknp siriwatknp siriwatknp approved these changes

@michaldudak michaldudak Awaiting requested review from michaldudak

Assignees

@hbjORbj hbjORbj

Labels
docs Improvements or additions to the documentation package: base-ui Specific to @mui/base package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hbjORbj @mui-bot @oliviertassinari @siriwatknp