[DatePicker] add function signatures to docs #3652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * will always be null and the second argument will be the new Date instance. | ||
| * Callback function that is fired when the date value changes. | ||
| * | ||
| * @param {null} null Since there is no particular event associated with the change, the first argument will always |
There was a problem hiding this comment.
break this line in 2 please 😁
|
Thanks a lot, this was really helpful 👍 👍 😍 |
alitaheri
added
docs
|
Thanks @alitaheri :) |
|
Looking good 👍 👍 Thanks 😁 @callemall/material-ui Good to go 🍏 |
alitaheri
added
PR: Review Accepted
and removed
PR: needs revision
oliviertassinari
added a commit
that referenced
this pull request
Mar 10, 2016
[DatePicker] add function signatures to docs
|
@theosherry Thanks! |
37 tasks
This was referenced Aug 19, 2021
This was referenced Sep 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, a PR towards #3096 .
I left the
DateTimeFormatentry as it is because a signature for that seems beyond the scope of the docs.I wasn't sure how to handle two situations:
onDismiss, that take no arguments and aren't expected to return anything: how should their signature be represented? I just left them out.nullarguments, like withonChange: how should they be represented? They haveundefinedtype and require a name (null in this PR) with the current setup.Anyway, let me know what you think.