Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Fix type error when using inputTypeSearch class for outlined and filled inputs #36740

Merged
merged 2 commits into from
Apr 12, 2023
Merged

[TextField] Fix type error when using inputTypeSearch class for outlined and filled inputs #36740

merged 2 commits into from
Apr 12, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Apr 1, 2023 •
edited
Loading

@sai6855 sai6855 changed the title [TextField] [TextField] fix typescript error when using inputTypeSearch class Apr 1, 2023
@sai6855 sai6855 added typescript bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Apr 1, 2023
@mui-bot
Copy link

mui-bot commented Apr 1, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36740--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against b6bed2d

@sai6855 sai6855 requested review from mnajdova and ZeeshanTamboli and removed request for mnajdova April 1, 2023 05:14
@sai6855 sai6855 mentioned this pull request Apr 1, 2023
Merged
1 task
@sai6855 sai6855 changed the title [TextField] fix typescript error when using inputTypeSearch class [TextField] fix typescript error when using inputTypeSearch class Apr 1, 2023
@sai6855 sai6855 requested a review from mnajdova April 2, 2023 12:30
ZeeshanTamboli
ZeeshanTamboli approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZeeshanTamboli ZeeshanTamboli changed the title [TextField] fix typescript error when using inputTypeSearch class [TextField] Fix typescript error when using inputTypeSearch class for outlined and filled inputs Apr 12, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [TextField] Fix typescript error when using inputTypeSearch class for outlined and filled inputs [TextField] Fix type error when using inputTypeSearch class for outlined and filled inputs Apr 12, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 4109ca1 into mui:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TextField] Typescript error when using inputTypeSearch class
3 participants
@sai6855 @mui-bot @ZeeshanTamboli