[website] Update main data grid demo on X landing page #37001
Conversation
cherniavskii
added
website
| totalPrice: 'max', | ||
| }, [data.columns]); | ||
|
|
||
| const initialState = useKeepGroupedColumnsHidden({ |
There was a problem hiding this comment.
useKeepGroupedColumnsHidden fixes the missing Commodities column when you stop grouping by it
| rowGroupingModel={rowGroupingModel} | ||
| onRowGroupingModelChange={(model) => setRowGroupingModel(model)} | ||
| aggregationModel={aggregationModel} | ||
| onAggregationModelChange={(newModel) => setAggregationModel(newModel)} | ||
| columnVisibilityModel={columnVisibilityModel} | ||
| onColumnVisibilityModelChange={(newModel) => setColumnVisibilityModel(newModel)} |
There was a problem hiding this comment.
There's no need to use controlled models for this, initialState should be enough here
Netlify deploy previewhttps://deploy-preview-37001--material-ui.netlify.app/ Bundle size report |
| editable: true, | ||
| visibleFields, |
There was a problem hiding this comment.
visibleFields allows to pick specific columns. This allows to remove the duplicated column definitions.
|
I'm coming from a recent regression in the SEO performance of pages https://search.google.com/search-console/core-web-vitals/drilldown?resource_id=sc-domain%3Amui.com&item_key=CAIQAhgD. It seems that we aren't done yet with this page 😁 
A few things I can spot we can improve:
Screen.Recording.2023-05-14.at.00.46.58.movMaybe the issue comes from that we render too many rows, but it seems to be 10,000 it's not 100,000, I would expect it to be x10 faster. I would feel more comfortable with what we were displaying before.
For example, we can copy what's done in https://mui.com/core/, it doesn't jump when the page is loading.
I think it was better before, either to revert or improve, but I don't think we should keep the current state too long. |
This performance issue is tracked in mui/mui-x#8579, we are working on a fix.
Yes, we had an issue with data generator 😅 It's fixed now 👍 Regarding the rest of your points - I will submit a PR to address them, thanks for your feedback! |
|
@cherniavskii Awesome thanks, very thorough. |
Preview: https://deploy-preview-37001--material-ui.netlify.app/x/