[website] X component section improvements #36598

danilo-leal · 2023-03-21T14:19:34Z

This PR consists of a few fine-tuning changes to the website's X component section. I mostly standardized Button styles and made the copy slightly more exciting (?!) for components that are either available as stable or in the lab (Date Picker & Tree View respectively).

👉 https://deploy-preview-36598--material-ui.netlify.app/x/

Date Range Picker

Before	After

Tree View

Figured we don't need the email subscription here as it's already available for usage, regardless if it's in the lab. I'd leave it there only if it was a PNG preview.

Before	After

mui-bot · 2023-03-21T22:25:19Z

Netlify deploy preview

https://deploy-preview-36598--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against 0775531

joserodolfofreitas

Thanks for taking a look at this!

I updated a couple of demos so it displays the newer features.
I thought it'd be a small update, but seeing it now, it makes sense to break it down in another PR. I'll iterate over the demos in the next few days.

docs/src/components/productX/XDateRangeDemo.tsx

Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

danilo-leal · 2023-04-11T01:12:06Z

@joserodolfofreitas let me know if this is good to go!

…e-section-tweaks

mnajdova

We likely need to update the x package to the latest release, there are some type issues going on. The changes in yarn.lock come as a dependencies of @mui/x-data-grid-generator. Probably someone on the X team can help.

danilo-leal · 2023-04-17T16:03:09Z

@joserodolfofreitas not a priority by any means but it'd be cool for you to give double-check here once possible!

joserodolfofreitas

That's good to go. Thank you!
I'll update the demos and x package versions on a separate PR.

edit: I just realized that we can't merge without fixing the type issues. So I'll take a look at that

danilo-leal · 2023-04-20T14:03:56Z

I was just about to ask you that! Thanks 🙌

joserodolfofreitas · 2023-04-20T18:05:35Z

@danilo-leal, now it's good to go ;)

danilo-leal · 2023-04-20T21:24:55Z

@joserodolfofreitas sweet! Thanks for the work in resolving all of this 🙌

cherniavskii · 2023-04-24T15:49:04Z

docs/src/components/productX/XHero.tsx

@@ -174,13 +276,28 @@ export default function XHero() {
                  }),
              ]}
            >
-              <DataGridPro
+              <DataGridPremium


@joserodolfofreitas I've submitted a follow-up PR for this demo: #37001

URLs should be kebab-case. The issue originate from #36598. Also see https://answers.netlify.com/t/no-trailing-slash-when-using-proxies/48790/20 for why we don't have a proper 301 with MUI X pages. Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>

oliviertassinari · 2023-04-28T13:55:53Z

docs/src/components/productX/XDateRangeDemo.tsx

-            href="/x/react-date-pickers/date-range-picker/"
+          <Button
+            variant="outlined"
+            href="/x/react-Date-pickers/Date-range-picker/"


Fixed in 5530804

oliviertassinari · 2023-05-01T03:15:58Z

docs/data/material/components/table/DataTable.tsx

-        pageSize={5}
-        rowsPerPageOptions={[5]}
+        paginationModel={{ page: 0, pageSize: 5 }}


Are we sure about this change? Clicking on the page button no longer work: https://deploy-preview-36598--material-ui.netlify.app/material-ui/react-table/#data-table

I'm coming from: https://mui-org.slack.com/archives/C041SDSF32L/p1682708252800599 cc @cherniavskii for guidance.

Right, I'll submit a PR 👍 #37114

URLs should be kebab-case. The issue originate from mui#36598. Also see https://answers.netlify.com/t/no-trailing-slash-when-using-proxies/48790/20 for why we don't have a proper 301 with MUI X pages. Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>

add X-components section tweaks

3eeab1e

danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Mar 21, 2023

danilo-leal requested review from joserodolfofreitas and gerdadesign March 21, 2023 14:19

danilo-leal and others added 3 commits March 21, 2023 20:59

delete unused commented code

0e0a370

Update main data grid demo with Premium features

608dc44

Add shortcuts to date range demo

195e56f

joserodolfofreitas reviewed Mar 24, 2023

View reviewed changes

docs/src/components/productX/XDateRangeDemo.tsx Show resolved Hide resolved

docs/src/components/productX/XDateRangeDemo.tsx Outdated Show resolved Hide resolved

joserodolfofreitas self-requested a review March 25, 2023 07:33

danilo-leal added 3 commits March 28, 2023 09:06

change label

9145fb2

checkout test error: yarn deduplicate

6a1cd2c

yarn docs:api

e41e893

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 10, 2023

Merge branch 'master' into x-components-website-section-tweaks

26a60fe

Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 11, 2023

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 11, 2023

Merge remote-tracking branch 'origin/master' into x-components-websit…

d2e1f81

…e-section-tweaks

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 17, 2023

mnajdova added 2 commits April 17, 2023 16:01

Merge branch 'master' into x-components-website-section-tweaks

39f30da

yarn.lock

b345b33

mnajdova reviewed Apr 17, 2023

View reviewed changes

joserodolfofreitas approved these changes Apr 20, 2023

View reviewed changes

joserodolfofreitas added 4 commits April 20, 2023 16:07

Update x packages

44d7bfe

Less shortcuts so date range demo fits better on the box

ee76ef0

Fix alignment on date range shortcuts

0c3eca1

Migrate X components APIs to v6 and fix type issues

ab16fa6

joserodolfofreitas added 6 commits April 20, 2023 17:25

Prettier and traspile

3a76c95

Display date selection on landing page demo by default. docs:formatted

8482aa5

Prettier

afaffc0

Reorganize date range demo imports

1d62eb9

Small polishing on data grid main demo

0c4c8ca

Lint

0775531

danilo-leal merged commit ce06cb9 into master Apr 20, 2023

danilo-leal deleted the x-components-website-section-tweaks branch April 20, 2023 21:25

cherniavskii reviewed Apr 24, 2023

View reviewed changes

oliviertassinari reviewed Apr 28, 2023

View reviewed changes

oliviertassinari reviewed May 1, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[website] X component section improvements #36598

[website] X component section improvements #36598

danilo-leal commented Mar 21, 2023 •

edited

Loading

mui-bot commented Mar 21, 2023 •

edited

Loading

joserodolfofreitas left a comment

danilo-leal commented Apr 11, 2023

mnajdova left a comment •

edited

Loading

danilo-leal commented Apr 17, 2023

joserodolfofreitas left a comment •

edited

Loading

danilo-leal commented Apr 20, 2023

joserodolfofreitas commented Apr 20, 2023

danilo-leal commented Apr 20, 2023

cherniavskii Apr 24, 2023

oliviertassinari Apr 28, 2023

oliviertassinari May 1, 2023 •

edited

Loading

cherniavskii May 1, 2023 •

edited by oliviertassinari

Loading

[website] X component section improvements #36598

[website] X component section improvements #36598

Conversation

danilo-leal commented Mar 21, 2023 • edited Loading

Date Range Picker

Tree View

mui-bot commented Mar 21, 2023 • edited Loading

Netlify deploy preview

Bundle size report

joserodolfofreitas left a comment

Choose a reason for hiding this comment

danilo-leal commented Apr 11, 2023

mnajdova left a comment • edited Loading

Choose a reason for hiding this comment

danilo-leal commented Apr 17, 2023

joserodolfofreitas left a comment • edited Loading

Choose a reason for hiding this comment

danilo-leal commented Apr 20, 2023

joserodolfofreitas commented Apr 20, 2023

danilo-leal commented Apr 20, 2023

cherniavskii Apr 24, 2023

Choose a reason for hiding this comment

oliviertassinari Apr 28, 2023

Choose a reason for hiding this comment

oliviertassinari May 1, 2023 • edited Loading

Choose a reason for hiding this comment

cherniavskii May 1, 2023 • edited by oliviertassinari Loading

Choose a reason for hiding this comment

danilo-leal commented Mar 21, 2023 •

edited

Loading

mui-bot commented Mar 21, 2023 •

edited

Loading

mnajdova left a comment •

edited

Loading

joserodolfofreitas left a comment •

edited

Loading

oliviertassinari May 1, 2023 •

edited

Loading

cherniavskii May 1, 2023 •

edited by oliviertassinari

Loading