-
-
Notifications
You must be signed in to change notification settings - Fork 32k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] X component section improvements #36598
Conversation
Netlify deploy previewhttps://deploy-preview-36598--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look at this!
I updated a couple of demos so it displays the newer features.
I thought it'd be a small update, but seeing it now, it makes sense to break it down in another PR. I'll iterate over the demos in the next few days.
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@joserodolfofreitas let me know if this is good to go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We likely need to update the x package to the latest release, there are some type issues going on. The changes in yarn.lock come as a dependencies of @mui/x-data-grid-generator. Probably someone on the X team can help.
@joserodolfofreitas not a priority by any means but it'd be cool for you to give double-check here once possible! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good to go. Thank you!
I'll update the demos and x package versions on a separate PR.
edit: I just realized that we can't merge without fixing the type issues. So I'll take a look at that
I was just about to ask you that! Thanks 🙌 |
@danilo-leal, now it's good to go ;) |
@joserodolfofreitas sweet! Thanks for the work in resolving all of this 🙌 |
@@ -174,13 +276,28 @@ export default function XHero() { | |||
}), | |||
]} | |||
> | |||
<DataGridPro | |||
<DataGridPremium |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joserodolfofreitas I've submitted a follow-up PR for this demo: #37001
URLs should be kebab-case. The issue originate from #36598. Also see https://answers.netlify.com/t/no-trailing-slash-when-using-proxies/48790/20 for why we don't have a proper 301 with MUI X pages. Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
href="/x/react-date-pickers/date-range-picker/" | ||
<Button | ||
variant="outlined" | ||
href="/x/react-Date-pickers/Date-range-picker/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 5530804
pageSize={5} | ||
rowsPerPageOptions={[5]} | ||
paginationModel={{ page: 0, pageSize: 5 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure about this change? Clicking on the page button no longer work: https://deploy-preview-36598--material-ui.netlify.app/material-ui/react-table/#data-table
I'm coming from: https://mui-org.slack.com/archives/C041SDSF32L/p1682708252800599 cc @cherniavskii for guidance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I'll submit a PR 👍 #37114
URLs should be kebab-case. The issue originate from mui#36598. Also see https://answers.netlify.com/t/no-trailing-slash-when-using-proxies/48790/20 for why we don't have a proper 301 with MUI X pages. Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
This PR consists of a few fine-tuning changes to the website's X component section. I mostly standardized Button styles and made the copy slightly more exciting (?!) for components that are either available as stable or in the lab (Date Picker & Tree View respectively).
👉 https://deploy-preview-36598--material-ui.netlify.app/x/
Date Range Picker
Tree View
Figured we don't need the email subscription here as it's already available for usage, regardless if it's in the lab. I'd leave it there only if it was a PNG preview.