[Switch][base] Drop component prop #37053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbjORbj
added
breaking change
component: switch
19 tasks
Netlify deploy previewBundle size report |
michaldudak
reviewed
Apr 28, 2023
| <Switch component={Root} {...label} /> | ||
| <Switch component={Root} {...label} defaultChecked disabled /> | ||
| <Switch component={Root} {...label} disabled /> | ||
| <Switch<typeof Root> |
There was a problem hiding this comment.
The generic parameter is needed only when you want to use a prop that's available on the root slot. It's not the case here, so we can simplify and remove it. (x other places)
github-actions
bot
added
the
PR: out-of-date
hbjORbj
force-pushed
the
switch/componentProp
branch
from
1d00aa8
to
fed960e
Compare
github-actions
bot
removed
the
PR: out-of-date
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.