Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Autocomplete scroll #37217

Merged
merged 9 commits into from
May 16, 2023
Merged

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 9, 2023

closes : #37127

working video:

screen-recording-2023-05-15-at-112648-pm_LTrVSiPK.mov

preview: https://deploy-preview-37217--material-ui.netlify.app/joy-ui/getting-started/templates/profile-dashboard/

@sai6855 sai6855 marked this pull request as draft May 9, 2023 13:57
@sai6855 sai6855 added bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels May 9, 2023
@mui-bot
Copy link

mui-bot commented May 9, 2023

Netlify deploy preview

https://deploy-preview-37217--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against 37add15

}}
autoFocus
/>
<Select defaultValue="1">
Copy link
Contributor Author

@sai6855 sai6855 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Focused option not scrolled into view is happening only when multiple elements with role listbox are rendered, hence added Select in the test

@sai6855 sai6855 marked this pull request as ready for review May 15, 2023 18:01
@sai6855 sai6855 requested a review from siriwatknp May 15, 2023 18:01
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the fix!

@siriwatknp siriwatknp merged commit b88e3b6 into mui:master May 16, 2023
@sai6855 sai6855 deleted the jou-autocomplete-scroll branch May 16, 2023 09:34
binh1298 pushed a commit to binh1298/material-ui that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: autocomplete This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Autocomplete][joy] scroll into view does not work
3 participants