[docs][base] Add page for all Base UI components #37536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
13 tasks
Netlify deploy previewBundle size report |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
siriwatknp
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
👏 Great work @danilo-leal.
Pushed aspect-ratio equal to the image size to prevent layout shift on first load.
siriwatknp
reviewed
Jun 14, 2023
|
I love it! There's one issue with how the images are displayed, though. On my screen (1.5x scaling, Windows), the text doesn't look crisp: 
It could be because the intrinsic size of the image is not an even (or x0.5) multiply of the rendered size. Could you please verify that? |
|
Oh shoot, sure. I'll open a follow-up PR tackling that — thanks for pointing it out! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an "All components" page that displays all available Base UI components. It's being created mostly because we want to have a button on the landing page that directs folks to a place where they can see from a glance everything that's there to use.
It is currently sorted alphabetically but if we think it's worth it, we can both add a filter + sort it categorically (as the side nav is) in the future. I made it that way purely because it was the easiest route, to begin with!
Preview: https://deploy-preview-37536--material-ui.netlify.app/base-ui/react-components/