Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Base UI marketing page #36622

Merged
merged 205 commits into from
Jul 18, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 23, 2023

Introducing Base UI as a stable product within the MUI Core line.
https://deploy-preview-36622--material-ui.netlify.app/base-ui/

Landing page tasks

  • Add animations to the hero section so it pops out more ✨
  • Sort the image size optimization on the Testimonial section.
  • Iterate further on the Hero section to make it both more understandable + more impactful. ⚠️
  • Add a page that shows all supported components so we can link the "Much more" to it. [docs][base] Add page for all Base UI components #37536
  • Finalize the Components section Tailwind CSS and Plain CSS demos.
  • Sort the horizontal scrolling on the Components section.
  • Fix the z-index issue on the Menu demo within the Components section.

Tangential tasks


@siriwatknp siriwatknp added the website Pages that are not documentation-related, marketing-focused. label Mar 23, 2023
@mui-bot
Copy link

mui-bot commented Mar 23, 2023

Netlify deploy preview

https://deploy-preview-36622--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9950524

@siriwatknp siriwatknp added this to the MUI Base stable release milestone Apr 13, 2023
@danilo-leal danilo-leal added the package: base-ui Specific to @mui/base label Apr 19, 2023
Copy link
Member Author

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilo-leal I Need some clarification on the new font so that we can optimize them similar to what I did with PlusJarkarta, the rest looks good.

Copy link
Member Author

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilo-leal The font flash is fixed (I did it for IBM Plex Sans regular as well). I can't approve my PR so feel free to merge when you think it is ready.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2023
@mnajdova
Copy link
Member

Few ideas for improvement:

  • The Accessibility card points to a section that does not cover anything related to accessibility
  • image
    We should link to a page or explain a bit how it is different
  • image
    The shadow on the inputs for Base UI looks a bit too much

@danilo-leal
Copy link
Contributor

danilo-leal commented Jul 18, 2023

Sweet, these are all good points!

  • re A11y page: yeah, there isn't a specific section in the docs covering the specifics of accessibility on Base. We should definitely write it and come back to the landing page to link it!
  • re Competitor difference: uhm, that's interesting! I wonder if it should live on the landing page, though... but either way, it's a good point to call out specific differentiators from the competition. Would love to get your & Michal's help to dig in further on that.
  • re Input shadow: that's on the docs intro demo rather than in the landing page, right? We can definitely polish it!

Just reiterating that given the merge of this PR and the marketing/promotion of the page are separate things, don't think these points are blockers! We should for sure iterate/work on them following the merge 🤙

And for the sake of alignment, we agreed on merging this PR as it houses a bunch of general style updates to the website/documentation and to hold on to the actual Base UI page promotion until possibly the end of the northern hemisphere summer to potentially bundle it up with the Joy UI stable.

@mnajdova let me know if all of this makes sense and if you think it's ready to go! 😄

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to get this one out! 🎉

@danilo-leal danilo-leal merged commit 3c99d8b into mui:master Jul 18, 2023
21 checks passed
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 20, 2023

It's awesome to have this page 🎉


A review on the page: https://mui.com/base-ui/. Opportunities we could use to improve it. I'm adding @zanivan to the loop as this can often be applied to the core in general. Here is what I think would move us to state-of-the-art.
I think that fixing these is part of what it takes to standout for Twitter, our exigeant users, they will notice them all IMHO:

Screen.Recording.2023-07-21.at.00.07.14.mov
  • 9 The focus visible style on the lower demo is soo much better:

Eww
Screenshot 2023-07-21 at 00 20 14

Great
Screenshot 2023-07-21 at 00 18 26

  • 12. We are missing a clean focus visible style on all the elements:
Screenshot 2023-07-21 at 00 46 53

In the doubt, I think using the same one as Joy UI would make sense.

  • 6 The label isn't wired to the select, also clicking on it should focus the select
Screenshot 2023-07-21 at 00 09 55
  • 2 Slider animation. This feels super nice on my end:
Screen.Recording.2023-07-20.at.23.29.45.mov

I haven't seen any other libraries do this, but it's so smooth (click jump https://m2.material.io/components/sliders#discrete-sliders)

  • 3 I think that white could feel a great step forward:
Screenshot 2023-07-20 at 23 38 23 Screenshot 2023-07-20 at 23 57 27
  • 7 Changing the color for each style could help reinforce the difference
Screenshot 2023-07-21 at 00 13 16
  • 8 I feel like the dropdown misses an open and close animation
Screenshot 2023-07-21 at 00 20 25
Screen.Recording.2023-07-21.at.00.21.56.mov

This is a bug with Joy UI and Material UI as well.

Screenshot 2023-07-21 at 00 30 21
  • 13. Something I noticed while behind surprised I could select the text in the button. This looks correct here. However, there is a bug in Material UI cc @DiegoAndai and Joy UI cc @siriwatknp, both get it wrong, but in a different way 😆

  • 15. Background color

Correct

Screenshot 2023-08-14 at 19 50 10

Wrong

Screenshot 2023-08-14 at 19 49 10
Screen.Recording.2023-07-20.at.23.52.34.mov

Material UI, I would argue that when the button is a <button> we should be able to select text, relying on the default browser behavior.

Screen.Recording.2023-07-21.at.01.39.03.mov

Related to whatwg/html#8228


Enjoy 😁

@danilo-leal
Copy link
Contributor

@oliviertassinari sweet, appreciate the thorough & detailed feedback! 😬 Two clarifying questions, though:

  • Bullet 3 wasn't clear, what do you mean by "white could feel a great step forward"?
  • I'm feeling like bullet 13 is sort of unrelated to this PR/page and it's something that would deserve an issue for both Material & Joy? Parting from "This looks correct here" I'm assuming that there's no change to be made on any page-related file, right? 🤔

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 21, 2023

  • 3 In dark mode, it feels OK on my end. But in light mode, I don't find that the button with the #000000 black background color has enough contrast with the text to be read easily. #0000ff blue -> #ffffff white could solve this.
  • 13 Agree, I noticed this while I could select the text of the button, at first I was surprised / thought it was wrong, but diving deeper, it actually looks like it's my expectation that is wrong: Base UI got it right. So Material UI & Joy UI that gets it wrong.

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 23, 2023

Actually on 13. it directly connects to a UX pain on the page. In the beginning of the video, I have no idea of the copy click feature, I just want to copy the text, I can't. Then, in the second part of the video, I remove the user-select: none CSS.

Screen.Recording.2023-07-23.at.02.05.15.mov

I think they do it right:

Screen.Recording.2023-07-23.at.02.07.04.mov

@DiegoAndai
Copy link
Member

DiegoAndai commented Jul 25, 2023

Created #38158 to address point 13.

In Firefox, the button text will still be not selectable, as that's their default (check https://nextjs.org/ on that browser).

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 27, 2023

Once we complet the round of polish on the marketing page, I think that we can announce it on Twitter, it will make for a great content, e.g. https://twitter.com/colmtuite/status/1453021328274034694.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: base-ui Specific to @mui/base website Pages that are not documentation-related, marketing-focused.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet