Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Clean up the GetStartedButtons component #38256

Merged
merged 12 commits into from
Aug 8, 2023
Merged

[website] Clean up the GetStartedButtons component #38256

merged 12 commits into from
Aug 8, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Aug 1, 2023 •
edited

Changes on this PR

  • Delete the redundant GetStartedButtons2 created while developing the Base UI page.
  • Adds the alternative installation command button in the GetStartedButton through the altInstallation prop.
  • Rename props now that this component can take different buttons other than just a main CTA & installation button.
  • Removes the user-select: none from the NpmCopyButton as per this feedback: [website] Add Base UI marketing page #36622 (comment)

Not 100% sure if the tweaked prop names are the best (I liked the simpler to and callToAction better!) 😬
I'm open to suggestions here if there are better options!

https://deploy-preview-38256--material-ui.netlify.app/base-ui

@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Aug 1, 2023
@danilo-leal danilo-leal self-assigned this Aug 1, 2023
@danilo-leal danilo-leal mentioned this pull request Aug 2, 2023
Closed
1 task
@bharatkashyap bharatkashyap mentioned this pull request Aug 2, 2023
Merged
oliviertassinari
oliviertassinari reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

docs/src/components/action/NpmCopyButton.tsx Show resolved Hide resolved
docs/src/components/action/NpmCopyButton.tsx Outdated Show resolved Hide resolved
docs/src/components/action/NpmCopyButton.tsx Outdated Show resolved Hide resolved
docs/src/components/action/NpmCopyButton.tsx Outdated Show resolved Hide resolved
docs/src/components/action/NpmCopyButton.tsx Outdated Show resolved Hide resolved
docs/src/components/action/NpmCopyButton.tsx Outdated Show resolved Hide resolved
docs/src/components/productMaterial/MaterialHero.tsx Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari mentioned this pull request Aug 2, 2023
Merged
@mui-bot
Copy link

mui-bot commented Aug 2, 2023 •
edited

Netlify deploy preview

https://deploy-preview-38256--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a582fbd

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 3, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 4, 2023
@danilo-leal
Copy link
Contributor Author

@siriwatknp & @bharatkashyap would appreciate a double-check on this one! 😬 Would love to merge it this week.

bharatkashyap
bharatkashyap approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for this effort 🙏

@danilo-leal danilo-leal merged commit d3cd842 into master Aug 8, 2023
24 checks passed
@danilo-leal danilo-leal deleted the base-ui-page-command-button-improvement branch August 8, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees

@danilo-leal danilo-leal

Labels
website Pages that are not documentation-related, marketing-focused.
Projects
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danilo-leal @mui-bot @oliviertassinari @siriwatknp @bharatkashyap