Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][material-ui] Improve nav link tab example #38315

Merged
merged 3 commits into from
Aug 15, 2023
Merged

[docs][material-ui] Improve nav link tab example #38315

merged 3 commits into from
Aug 15, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 4, 2023 •
edited
Loading

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Aug 4, 2023
@mui-bot
Copy link

mui-bot commented Aug 4, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 13b28c7

ZeeshanTamboli
ZeeshanTamboli reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change thesehrefs to href="/" even though we are preventing the link from following the URL?

@ZeeshanTamboli ZeeshanTamboli added the component: tabs This is the name of the generic UI component, not the React module! label Aug 15, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 15, 2023 •
edited
Loading

Should we change thesehrefs to href="/" even though we are preventing the link from following the URL?

No, I don't think so, the point is that CMD + click and for SEO, it points to the right URL.

@oliviertassinari oliviertassinari merged commit cc04532 into mui:master Aug 15, 2023
19 checks passed
@oliviertassinari oliviertassinari deleted the tabs-material-ui branch August 15, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nav Tabs variant of Tabs does not respect metakey clicks
3 participants
@oliviertassinari @mui-bot @ZeeshanTamboli