Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Refine the Order Dashboard template design #38395

Merged
merged 17 commits into from
Aug 10, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Aug 9, 2023

Refining the Order Dashboard template aiming to remove most of the custom styles and overrides, making it closer as possible to the default theme.

Current New
image image

https://deploy-preview-38395--material-ui.netlify.app/joy-ui/getting-started/templates/order-dashboard/

@zanivan zanivan added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Aug 9, 2023
@mui-bot
Copy link

mui-bot commented Aug 9, 2023

Netlify deploy preview

https://deploy-preview-38395--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 8943ad2

@zanivan zanivan self-assigned this Aug 9, 2023
@danilo-leal danilo-leal changed the title [docs][joy] Refine Joy UI order-dashboard template [docs][joy-ui] Refine the Order Dashboard template design Aug 9, 2023
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this now! 😊

@zanivan zanivan requested a review from siriwatknp August 9, 2023 21:52
@zanivan
Copy link
Contributor Author

zanivan commented Aug 9, 2023

@siriwatknp I'm refining the old templates, can you review it from the development POV? Mostly, if what we're doing is the best way to do it.
And one more thing, is there an easy way to update the screenshots afterward? I remember you did it on the default theme, but I couldn't find it among those hundreds of commits 😅

@siriwatknp
Copy link
Member

siriwatknp commented Aug 10, 2023

And one more thing, is there an easy way to update the screenshots afterward? I remember you did it on the default theme, but I couldn't find it among those hundreds of commits 😅

Run yarn template:screenshot while running the development server.

@siriwatknp
Copy link
Member

siriwatknp commented Aug 10, 2023

image

@zanivan I notice that the sidebar in the mobile viewport does not have a border, is this expected?

@danilo-leal
Copy link
Contributor

@siriwatknp it should have ⎯ at least between the first and second side nav! Tried adding it but didn't figure out why... mind pointing out the way? 😬

@siriwatknp
Copy link
Member

@siriwatknp it should have ⎯ at least between the first and second side nav! Tried adding it but didn't figure out why... mind pointing out the way? 😬

Alright, fixed it. The previous version uses Dividers. I replaced them with border instead, so it both work on mobile and desktop.

@zanivan zanivan merged commit fe17074 into mui:master Aug 10, 2023
18 checks passed
@zanivan zanivan mentioned this pull request Aug 21, 2023
10 tasks
subscription: 'Monthly',
},
{
id: 'INV-1232',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new IDs weren't unique, it created console error spam in the console, fixed in #40316.

Learning, please continuously check that new code is free of warnings from:

👌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these learning links; much appreciated! More than just pointing something as wrong, learning about how to prevent it in the future is crucial, particularly for us designers who sometimes miss these more "under the hood" dev things! 🤙 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

5 participants