-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Refine the Order Dashboard template design #38395
Conversation
Netlify deploy previewhttps://deploy-preview-38395--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this now! 😊
@siriwatknp I'm refining the old templates, can you review it from the development POV? Mostly, if what we're doing is the best way to do it. |
docs/data/joy/getting-started/templates/order-dashboard/components/SecondSidebar.tsx
Outdated
Show resolved
Hide resolved
Run |
@zanivan I notice that the sidebar in the mobile viewport does not have a border, is this expected? |
@siriwatknp it should have ⎯ at least between the first and second side nav! Tried adding it but didn't figure out why... mind pointing out the way? 😬 |
Alright, fixed it. The previous version uses Dividers. I replaced them with border instead, so it both work on mobile and desktop. |
subscription: 'Monthly', | ||
}, | ||
{ | ||
id: 'INV-1232', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new IDs weren't unique, it created console error spam in the console, fixed in #40316.
Learning, please continuously check that new code is free of warnings from:
- Best practices: https://pagespeed.web.dev/
- Spec https://validator.w3.org/
- Accessibility tool https://chromewebstore.google.com/detail/wave-evaluation-tool/jbbplnpkjmmeebjpijfedlgcdilocofh
- console warnings
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these learning links; much appreciated! More than just pointing something as wrong, learning about how to prevent it in the future is crucial, particularly for us designers who sometimes miss these more "under the hood" dev things! 🤙 Thanks!
Refining the Order Dashboard template aiming to remove most of the custom styles and overrides, making it closer as possible to the default theme.
https://deploy-preview-38395--material-ui.netlify.app/joy-ui/getting-started/templates/order-dashboard/