[docs][joy-ui] Fix dashboard template console errors #40316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
oliviertassinari
changed the title
Netlify deploy previewhttps://deploy-preview-40316--material-ui.netlify.app/ Bundle size report |
mnajdova
approved these changes
Dec 26, 2023
1 task
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This template wasn't usable IMHO, I'm a new user, overwhelmed, short in time: I see this, I close my tab 馃槃
Before
Screen.Recording.2023-12-26.at.00.14.44.mov
http://0.0.0.0:3000/joy-ui/getting-started/templates/order-dashboard/
After
The error is gone. There are still others in the Joy UI templates, but at least this massive spam is gone.
Noticed by chance while I was fixing #40315. Now, to be fair, I still don't think that this template is fully usable in production for a developer if you compare the report of:
between https://ui.shadcn.com/examples/dashboard and https://mui.com/joy-ui/getting-started/templates/order-dashboard/ it's a completely different story (Shadcn is close to having no problems). Or at least, we negatively differentiate with it (makes Shadcn more appealing) in this dimension.