Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] v5.14.9 #38920

Merged
merged 14 commits into from Sep 13, 2023
Merged

[release] v5.14.9 #38920

merged 14 commits into from Sep 13, 2023

Conversation

DiegoAndai
Copy link
Member

PR for the release of version 5.14.9

@DiegoAndai DiegoAndai added the release We are shipping :D label Sep 11, 2023
@DiegoAndai DiegoAndai self-assigned this Sep 11, 2023
@DiegoAndai DiegoAndai changed the title v5.14.9 [release] v5.14.9 Sep 11, 2023
@DiegoAndai DiegoAndai requested a review from a team September 11, 2023 16:21
@mui-bot
Copy link

mui-bot commented Sep 11, 2023

Netlify deploy preview

https://deploy-preview-38920--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 0e84cb6

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

A big thanks to the 15 contributors who made this release possible. Here are some highlights ✨:

- 🎉 Added `Drawer` component to Joy UI (#38169) @mnajdova
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to the docs could be great. Or maybe even an image/video preview. We are not selling it 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link to the docs
@siriwatknp @zanivan, let me know if you have an image or video you wish to add 😊

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree here about images or video clips. We can brag about new features on social media, but the changelog should be concise and highlight changes from the previous version. It's not a means of marketing.

A link is fine, though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, a link is enough for the changelog.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree here about images or video clips. We can brag about new features on social media, but the changelog should be concise and highlight changes from the previous version. It's not a means of marketing.

@michaldudak There are different schools on this.

  1. Changelog first: https://github.com/prisma/prisma/releases, https://github.com/drizzle-team/drizzle-orm/releases,
  2. Twitter first: https://github.com/chakra-ui/chakra-ui/releases https://github.com/shadcn-ui/ui/releases
  3. Blog posts first: https://github.com/microsoft/TypeScript/releases, https://nextjs.org/blog, https://v5.mantine.dev/changelog/5-8-0/
  4. Doesn't announce

I feel the problem in our case is that we fall most often under "Doesn't announce" 😁. I would be much in favor of 3.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@sai6855
Copy link
Contributor

sai6855 commented Sep 11, 2023

@DiegoAndai these PRs can be merged #38876 #38814 and maybe #38753 could also go

Comment on lines +55 to +57
"@mui/joy": "5.0.0-beta.6",
"@mui/material": "^5.14.9",
"@mui/material-next": "6.0.0-alpha.101",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Off-topic: not sure why the system has them as dev dependencies 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependencies are now explicit, we use them in the tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would challenge that having this here is a net-positive, I don't understand how #38859 (comment).

yarn.lock Outdated Show resolved Hide resolved
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versions look good to me, just a few open questions.

CHANGELOG.md Outdated Show resolved Hide resolved
ZeeshanTamboli and others added 2 commits September 12, 2023 20:46
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
@DiegoAndai
Copy link
Member Author

I think I discovered the cause of the yarn.lock unexpected update:

In #38859, the MUI packages were added explicitly to the root package.json.

Running yarn release:version didn't update these versions in the root package.json (file here). There's an existing issue about it. This is what caused the yarn.lock update, which is not correct.

@michaldudak, how might we proceed here?

cc: @ZeeshanTamboli @siriwatknp

@michaldudak
Copy link
Member

Sorry for causing trouble. I'm attempting a fix in #38940.

@DiegoAndai DiegoAndai merged commit 8255b71 into mui:master Sep 13, 2023
21 checks passed
@DiegoAndai DiegoAndai deleted the v5.14.9 branch September 13, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants