Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Refine the Email, Teams and Files templates #39579

Merged
merged 39 commits into from
Nov 17, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Oct 23, 2023

@zanivan zanivan added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Oct 23, 2023
@zanivan zanivan self-assigned this Oct 23, 2023
@zanivan zanivan mentioned this pull request Oct 23, 2023
10 tasks
@mui-bot
Copy link

mui-bot commented Oct 23, 2023

Netlify deploy preview

https://deploy-preview-39579--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 23f50e2

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great — thanks for taking it!

Overall, I think we can use this PR, or potentially in the next one (?) to standardize some stuff and add new components that weren't available when these templates were first done. Here are some ideas/things I've thought about:

  • Add accordions, aspect ratios, snackbars, breadcrumbs, etc.
  • Beef up the dummy data a bit to feel a bit more like a real app
  • Standardize icon button sizes
  • Enhance the template menu a bit — we can make something fancier
  • etc.

@zanivan
Copy link
Contributor Author

zanivan commented Oct 31, 2023

Hey @mnajdova, thanks so much for the help! I'll add a demo for non-modal dialog at the Joy UI docs afterward 🙌

@mnajdova mnajdova closed this Oct 31, 2023
@mnajdova mnajdova reopened this Oct 31, 2023
@mnajdova
Copy link
Member

I am sorry I misclicked 😀

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions. Overall, great improvement!

@zanivan zanivan requested a review from a team November 9, 2023 16:05
@zanivan
Copy link
Contributor Author

zanivan commented Nov 9, 2023

Hey @mui/design I'd really appreciate your input on these 😉 Are there any bugs we must fix, or improvements we can add?

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Awesome improvement!

@siriwatknp
Copy link
Member

@zanivan Can you remove the unused theme variable from

/tmp/material-ui/docs/data/joy/getting-started/templates/team/App.tsx
  141:14  error  'theme' is defined but never used  @typescript-eslint/no-unused-vars

✖ 1 problem (1 error, 0 warnings)

@mnajdova mnajdova merged commit 76c1b8b into mui:master Nov 17, 2023
20 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants