Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Templates] Update thumbnails #39938

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Nov 20, 2023

Run yarn template:screenshot to update templates screenshots after #39579

@zanivan zanivan added docs Improvements or additions to the documentation design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Nov 20, 2023
@zanivan zanivan self-assigned this Nov 20, 2023
@mui-bot
Copy link

mui-bot commented Nov 20, 2023

Netlify deploy preview

https://deploy-preview-39938--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d16b8e4

@zanivan
Copy link
Contributor Author

zanivan commented Nov 20, 2023

After run yarn template:screenshot some hydration error seems to be happening:

Screenshot 2023-11-20 at 10 43 18

@siriwatknp would you mind taking a look at this?

@danilo-leal danilo-leal added the package: joy-ui Specific to @mui/joy label Nov 21, 2023
@vitalijalbu
Copy link

This happens on avatar also, I had same error on my navbar.

siriwatknp

This comment was marked as outdated.

@zanivan zanivan merged commit ac99485 into mui:master Nov 23, 2023
19 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 30, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants