[material-ui] Add new Next.js integration package #39947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: material-ui
Netlify deploy previewBundle size report |
siriwatknp
changed the title
siriwatknp
removed
the
proof of concept
Co-authored-by: Marija Najdova <mnajdova@gmail.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
…/nextjs-integration
Done! |
konekoya
reviewed
Dec 4, 2023
nil1511
reviewed
Dec 4, 2023
mnajdova
approved these changes
Dec 5, 2023
danilo-leal
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Looking awesome! A few copy suggestions — @samuelsycamore feel free to double-check them, too! 😃
siriwatknp
commented
Dec 6, 2023
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
github-actions
bot
added
PR: out-of-date
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
1 task
1 task
This was referenced Dec 12, 2023
This was referenced Dec 25, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34575
Summary
new package:
@mui/material-nextjsversioning: follow Material UI, starts at 5.14.18
docs: replace the old page with https://deploy-preview-39947--material-ui.netlify.app/material-ui/guides/nextjs/
✅ Tested the code with mui docs and local project with code sandbox build
New feature
Added
enableCssLayerto the app router API to use@layerso that other styling solution, e.g. Taiwind or Pure CSS can override Material UI.Next step (in separate PRs)
Add Image and Link to this package.
Other approaches
❗️Using subfolder in Material UI does not work well because we need more than one folder (a separate package makes a lot more sense). See the discussion.
I have followed (at least) the PR section of the contributing guide.