-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Pin Node version on GitHub Actions to 18.18 #40187
Conversation
This reverts commit 0623e02.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script was updated in #39947. Should we change it back?
@ZeeshanTamboli I hadn't seen this change, but in principle it was the second option I suggested in #40173. So either undo the change to the script and change the Node.js version or keep the script and leave Node.js at 18.19. |
Just copying the notes from decision making in our code infra meeting:
|
Netlify deploy previewhttps://deploy-preview-40187--material-ui.netlify.app/ Bundle size report |
It turns out that #40080 is not the cause of this problem, as it updates Node on CircleCI, but the validate-declarations scripts runs on GitHub Actions. I updated this PR pinning the Node version for GH Actions and leaving the CircleCI version unpinned. |
ts-node doesn't work with Node 18.19 (see TypeStrong/ts-node#2094), causing issues with the validate-declarations script.
Pinning Node version on GitHub Actions for now. If ts-node is broken for a longer time, we'll think of a better solution.
Fixes #40173