Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Pin Node version on GitHub Actions to 18.18 #40187

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Dec 12, 2023

ts-node doesn't work with Node 18.19 (see TypeStrong/ts-node#2094), causing issues with the validate-declarations script.
Pinning Node version on GitHub Actions for now. If ts-node is broken for a longer time, we'll think of a better solution.

Fixes #40173

@michaldudak michaldudak added dependencies Update of dependencies core Infrastructure work going on behind the scenes labels Dec 12, 2023
@michaldudak michaldudak requested a review from a team December 12, 2023 13:42
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script was updated in #39947. Should we change it back?

@lhilgert9
Copy link
Contributor

The script was updated in #39947. Should we change it back?

@ZeeshanTamboli I hadn't seen this change, but in principle it was the second option I suggested in #40173. So either undo the change to the script and change the Node.js version or keep the script and leave Node.js at 18.19.

@Janpot
Copy link
Member

Janpot commented Dec 14, 2023

Just copying the notes from decision making in our code infra meeting:

  • let’s revert node.js version for now
  • let's revert changes to the ts-node command
  • let's update renovate.json to isolate node.js with a "description" field pointing to a github issue

@mui-bot
Copy link

mui-bot commented Dec 19, 2023

Netlify deploy preview

https://deploy-preview-40187--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d5d9d9b

@michaldudak
Copy link
Member Author

It turns out that #40080 is not the cause of this problem, as it updates Node on CircleCI, but the validate-declarations scripts runs on GitHub Actions. I updated this PR pinning the Node version for GH Actions and leaving the CircleCI version unpinned.

@michaldudak michaldudak changed the title Revert "Bump cimg/node Docker tag to v18.19" [core] Pin Node version on GitHub Actions to 18.18 Dec 19, 2023
@michaldudak michaldudak merged commit f02c79c into master Dec 20, 2023
25 checks passed
@michaldudak michaldudak deleted the revert-40080-renovate/cimg-node-18.x branch December 20, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] CI fails since Node.js 18.19.0
5 participants