Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Mark TreeView and Charts as stable #39975

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 23, 2023

| [Tree View - Multiselect](/x/react-tree-view/#multi-selection) | MUI X | 🧪 |
| Tree View - Virtualization | MUI X | ⏳ |
| Window Splitter | MUI X | ⏳ |
| Name | Product | Status |
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the entire table got diffed.
I just removed the nested tree view items and marked the tree view as stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because [Tree View - Multiselect](/x/react-tree-view/#multi-selection) was removed, reducing the width of the first column.

It looks like GitHub diff UI is broken, it's failing to show the diff correctly.

@flaviendelangle flaviendelangle self-assigned this Nov 23, 2023
@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! website Pages that are not documentation-related, marketing-focused. labels Nov 23, 2023
@flaviendelangle flaviendelangle changed the title [Website] Mark TreeView and Charts as stable [website] Mark TreeView and Charts as stable Nov 23, 2023
@mui-bot
Copy link

mui-bot commented Nov 23, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 4532a1f

Comment on lines +97 to +98
Using D3.js for data manipulation and SVG for rendering, Charts are now available on MUI
X!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be best to use a non-breaking space here to avoid:

I'm not sure GitHub suggestion UI is handling non-breaking space correctly anymore, I have tried this but it doesn't seem to work:

Suggested change
Using D3.js for data manipulation and SVG for rendering, Charts are now available on MUI
X!
Using D3.js for data manipulation and SVG for rendering, Charts are now available on MUI X!

It might need to be done with a direct commit.

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.
Don't bother too much with breaking space, because the text is removed in #39832

@danilo-leal I you get breaking changes on your PR, it' might be because of that one

@danilo-leal
Copy link
Contributor

@alexfauquette Oh, sweet, thanks for the heads-up! The marketing page demos will probably be re-worked on my PR that you linked but all good with the roadmap page changes here 🤙

@flaviendelangle flaviendelangle merged commit 553cf82 into mui:master Nov 27, 2023
21 of 22 checks passed
@flaviendelangle flaviendelangle deleted the tree-view-roadmap branch November 27, 2023 08:02
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Nov 30, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 1, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants