Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Replace recharts with MUI X charts on the Dashboard template #40107

Merged
merged 13 commits into from
Jan 9, 2024
Merged

[material-ui][docs] Replace recharts with MUI X charts on the Dashboard template #40107

merged 13 commits into from
Jan 9, 2024
+132 −266

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Dec 5, 2023 •
edited

Fixes mui/mui-x#10027

Blocking points:

  • The responsive container can overflow the parent: were do to the wrapping div style (data grid would have the same issue)

image

Before: https://deploy-preview-40106--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/
After: https://deploy-preview-40107--material-ui.netlify.app/material-ui/getting-started/templates/dashboard/

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts labels Dec 5, 2023
@alexfauquette alexfauquette marked this pull request as draft December 5, 2023 09:39
@mui-bot
Copy link

mui-bot commented Dec 5, 2023 •
edited

Netlify deploy preview

https://deploy-preview-40107--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1d19795

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 5, 2023
@danilo-leal danilo-leal added MUI X package: material-ui Specific to @mui/material labels Dec 5, 2023
@alexfauquette alexfauquette mentioned this pull request Dec 11, 2023
Merged
@alexfauquette alexfauquette mentioned this pull request Dec 11, 2023
Merged
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 12, 2023
@oliviertassinari oliviertassinari changed the title [draft] remove recharts from the docs [draft] Replace recharts from the template with MUI X Charts Dec 22, 2023
@alexfauquette alexfauquette mentioned this pull request Jan 2, 2024
Merged
@alexfauquette alexfauquette marked this pull request as ready for review January 8, 2024 09:31
@danilo-leal danilo-leal changed the title [draft] Replace recharts from the template with MUI X Charts [material-ui][docs] Replace recharts with MUI X charts on the Dashboard template Jan 8, 2024
danilo-leal
danilo-leal approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! 😌

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 9, 2024
@siriwatknp siriwatknp merged commit 191d684 into mui:master Jan 9, 2024
22 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
@alexfauquette @mnajdova
[material-ui][docs] Replace recharts with MUI X charts on the Dashboa…
070a85f 
…rd template (mui#40107)
@oliviertassinari oliviertassinari mentioned this pull request Feb 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
component: charts docs Improvements or additions to the documentation MUI X package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[charts][Dogfooding] Migrate charts in the docs
4 participants
@alexfauquette @mui-bot @danilo-leal @siriwatknp