[charts] Make the helper ChartsText component public
#11370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
the
component: charts
|
Deploy preview: https://deploy-preview-11370--material-ui-x.netlify.app/ |
3 tasks
LukasTy
changed the title
ChartsTextpublicChartsText component public
Co-authored-by: Lukas <llukas.tyla@gmail.com> Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
alexfauquette
added a commit
to alexfauquette/mui-x
that referenced
this pull request
Dec 22, 2023
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on mui/material-ui#40107 I realized that because we only support a subset of
dominantBaselinevalues, I can not pass directly theme styles without TS error.So I would need to have
ChartsTextStyletypes to write something likestyle: theme.typography.h2 as ChartsTextStyleInstead of exporting only the type, I'm making the entire component available. Could be usefull for devs looking to add a title or other muti-line text