[zero][Badge] Identify zero runtime styled path #40555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
changed the title
Netlify deploy previewhttps://deploy-preview-40555--material-ui.netlify.app/ Bundle size report |
brijeshb42
force-pushed
the
zero-intermediate-pkg-POC
branch
2 times, most recently
from
c99cfba
to
0c18fee
Compare
siriwatknp
reviewed
Jan 12, 2024
siriwatknp
reviewed
Jan 12, 2024
brijeshb42
force-pushed
the
zero-intermediate-pkg-POC
branch
3 times, most recently
from
b3c7d82
to
608c975
Compare
and replace emotion/system with zero runtime at build time.
brijeshb42
force-pushed
the
zero-intermediate-pkg-POC
branch
from
608c975
to
b9e72dc
Compare
brijeshb42
commented
Jan 12, 2024
| @@ -6,7 +6,7 @@ import { usePreviousProps } from '@mui/utils'; | |||
| import { unstable_composeClasses as composeClasses } from '@mui/base/composeClasses'; | |||
| import { useBadge } from '@mui/base/useBadge'; | |||
| import { useSlotProps } from '@mui/base'; | |||
| import styled from '../styles/styled'; | |||
| import { styled } from '../zero-styled'; | |||
There was a problem hiding this comment.
Added alternate way to specify zero-runtime readiness without the need of a separate package. The only requirement now is that the import path should end with /zero-styled. We can change this path as well.
The other approach seemed unnecessarily complex and required a side-effect file import.
brijeshb42
changed the title
mnajdova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and replace emotion/system with zero runtime at build time.
To test locally, see the README of this repo.