Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Tooltip] deprecate *Component and *Props for v6 #42120

Closed
wants to merge 22 commits into from

Conversation

lhilgert9
Copy link
Contributor

@lhilgert9 lhilgert9 commented May 4, 2024

Part of #41281.
@DiegoAndai

Question:
Is it important that className of PopperProps and slotProps.popper are both applied, because a test exists in Tooltip.test.js?

I've also seen that #42107 is being worked on. We should see that the changes in these two PR's go together.

@mui-bot
Copy link

mui-bot commented May 4, 2024

Netlify deploy preview

SpeedDialAction: parsed: +0.77% , gzip: +0.77%
Tooltip: parsed: +0.94% , gzip: +0.90%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against eb3f24d

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 4, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 4, 2024
@zannager zannager added the component: tooltip This is the name of the generic UI component, not the React module! label May 6, 2024
@zannager zannager requested a review from DiegoAndai May 6, 2024 16:19
@lhilgert9
Copy link
Contributor Author

CI fails because apparently the same popper element is not used in a rerender. I think that the error is in the useSlot hook. However, I have not found it yet. If anyone has an idea please let me know.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 20, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 25, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 30, 2024
@DiegoAndai
Copy link
Member

Hey @lhilgert9! thanks for working on this. Please see #41281 (comment).

@lhilgert9 lhilgert9 closed this May 31, 2024
@lhilgert9 lhilgert9 deleted the deprecate-tooltip-props branch July 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants