[material-ui][Snackbar] Deprecate *Component and *Props #42314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expanded the SnackbarProps interface to include SnackbarSlotsAndSlotProps, which includes transition related props.
…ps' and 'TransitionComponent'
Added instructions to migrate deprecated `TransitionComponent` and `TransitionProps` properties of the Snackbar component in the migration guide. Also, updated the mui-codemod README to document the changes.
zannager
added
the
component: snackbar
Updated Snackbar component's `ClickAwayListenerProps`, `ContentProps`, and `TransitionProps` to now be accessed via the `slotProps` prop for standardization and backwards compatibility. Deprecated the use of individual prop usage, set to be removed in v7.
Updated the Snackbar component in various test cases and documentation to reflect the deprecation of 'ClickAwayListenerProps' and 'ContentProps'. These properties are now recommended to be defined within 'slotProps'. Adjusted codemod transformations to handle this change.
All the slot props (`*Props`) in Snackbar have been marked as deprecated and replaced with equivalent `slotProps` entries. This change is reflected in both the migration guide and the README file of the mui-codemod package.
fedirjh
changed the title
github-actions
bot
added
the
PR: out-of-date
# Conflicts: # packages/mui-codemod/README.md
github-actions
bot
removed
the
PR: out-of-date
Streamlined the test logic for snackbar-props deprecations by using the describeJscodeshiftTransform utility.
github-actions
bot
added
the
PR: out-of-date
# Conflicts: # packages/mui-codemod/README.md
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
# Conflicts: # packages/mui-codemod/src/deprecations/all/deprecations-all.js
github-actions
bot
removed
the
PR: out-of-date
34 tasks
aarongarciah
assigned aarongarciah and DiegoAndai and unassigned aarongarciah and DiegoAndai
github-actions
bot
added
the
PR: out-of-date
# Conflicts: # packages/mui-codemod/src/deprecations/all/deprecations-all.js
github-actions
bot
removed
the
PR: out-of-date
|
Hey @fedirjh! thanks for working on this. Please see #41281 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #41281
Description
Deprecate
TransitionComponentin favor ofslots.Deprecate
TransitionProps,ClickAwayListenerPropsandContentPropsin favor ofslotProps.Added
snackbar-propssection in the migration guideAdded
snackbar-propscodemodI have followed (at least) the PR section of the contributing guide.