Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subheader] Remove desktop and focusState props from being passed to <div> #5893

Closed
wants to merge 3 commits into from
Closed

Conversation

billyvg
Copy link

@billyvg billyvg commented Jan 7, 2017

If you use a <Subheader> inside of a <Menu>, it can be passed these two props which are then passed to a <div>

Fixes #5830

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather have the Menu passing those properties to a white list of components. I think that we are leaking concerns here.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Jan 7, 2017
@billyvg
Copy link
Author

billyvg commented Jan 7, 2017

@oliviertassinari Should I create a new PR or update this one?

@muibot muibot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 7, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 8, 2017

Should I create a new PR or update this one?

What's the advantage of opening a new one? You can simply update this one.
Regarding the whitelist of components that the Menu should be highjacking, I haven't looked in detail but I believe MenuItem is the only one. We could be using node.type.muiName === 'MenuItem' as we do with the other components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants