[Menu] Fix support of any type of children

[oliviertassinari]

• PR has tests / docs demo, and is linted.
• Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
• Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

This is a continuation of #5893.
Thanks @billyvg for submitting the original PR.

Closes #5893.
Closes #5830.

[jbhatab]

@oliviertassinari you guys really need to change how you do versioning. upgrading from 16.6 to 16.7 shouldnt break my app and this is the third time upgrading material ui has broken something. I was using list item in select field before. I completely understand making these types of changes but it should at least be a major version upgrade when it breaks something.

[oliviertassinari]

third time upgrading material ui has broken something

@jbhatab I'm sorry about that. We do our best to identify breaking changes. When we find one, we follow the semantic versioning. But that's really hard with a UI library, the API is very large. There is no simple input -> output tests that we can write, unless project like this: babel-plugin-transform-react-remove-prop-types.

In this specific case, focus handling doesn't work correctly with <ListItem />. Besides, you should have had a warning like this one:

Warning: Unknown props desktop, focusState on tag.

From my perspective, it's not a breaking change as it wasn't supported.

[jbhatab]

oh I didn't know that warning was for that. makes sense. I definitely understand how hard it is to make changes but not break anything.

…

On Feb 4, 2017 2:10 AM, "Olivier Tassinari" ***@***.***> wrote: third time upgrading material ui has broken something @jbhatab <https://github.com/jbhatab> I'm sorry about that. We do our best to identify breaking changes. When we find one, we follow the semantic versioning <http://semver.org/>. But that's really hard with a UI library, the API is very large. There is no simple *input -> output* tests that we can write, unless project like this: babel-plugin-transform-react-remove-prop-types <https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types> . In this specific case, focus handling doesn't work correctly with <ListItem />. Besides, you should have had a warning like this one: Warning: Unknown props desktop, focusState on tag. From my perspective, it's not a breaking change as it wasn't supported. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5904 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWEXvtPqjNzSwY5Pb8J7hOJ0swdvqc2ks5rZE6hgaJpZM4Lf9nB> .