New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Slider] Fix isRtl
behaviour directionInvariant
approach
#6760
[Slider] Fix isRtl
behaviour directionInvariant
approach
#6760
Conversation
Direction invariant approach to #6736. As suggested by @oliviertassinari on #6744.
Closes #6736. Direction invariant approach as suggested by @oliviertassinari on #6744. To access the `axis` prop of the `Slider` make sure to use `calculateAxis`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried it but the code looks great 👍.
@omarchehab98 Thanks! |
@omarchehab98 Thanks ! @oliviertassinari , I think it's about time to publish a new version ? ;) |
@oliviertassinari, hope it's not rude, but can u please bump material-ui version? (in order to get this fix, since it's pretty critical bug..) Thanks |
@jony89 We try to release every two weeks. You gonna have to wait a bit or patch it locally. |
@oliviertassinari although there is a critical bug? is there a guide how to patch it locally or it's just one line of build? sorry for the not connected conversation.. |
|
Tnx, just wanted to make sure that there is nothing special :) |
Closes #6736, another approach to the issue as suggested by @oliviertassinari on #6744.
If this is approved, then it closes #6744.
Slider
direction invariant.axis
props based onisRtl