Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] Fix isRtl behaviour directionInvariant approach #6760

Merged
merged 2 commits into from May 3, 2017
Merged

[Slider] Fix isRtl behaviour directionInvariant approach #6760

merged 2 commits into from May 3, 2017

Conversation

omarchehab98
Copy link

@omarchehab98 omarchehab98 commented May 3, 2017

Closes #6736, another approach to the issue as suggested by @oliviertassinari on #6744.
If this is approved, then it closes #6744.

  • Made Slider direction invariant.
  • Transformed axis props based on isRtl

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Direction invariant approach to #6736. As suggested by @oliviertassinari on #6744.
Closes #6736. Direction invariant approach as suggested by @oliviertassinari on #6744. To access the `axis` prop of the `Slider` make sure to use `calculateAxis`.
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tried it but the code looks great 👍.

@oliviertassinari oliviertassinari added PR: Review Accepted bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! and removed PR: Needs Review labels May 3, 2017
@oliviertassinari oliviertassinari merged commit e2e2a00 into mui:master May 3, 2017
@oliviertassinari
Copy link
Member

@omarchehab98 Thanks!

@jony89
Copy link
Contributor

jony89 commented May 3, 2017

@omarchehab98 Thanks !

@oliviertassinari , I think it's about time to publish a new version ? ;)

@omarchehab98 omarchehab98 deleted the slider-isRtlDirectionInvariant branch May 3, 2017 11:43
@jony89
Copy link
Contributor

jony89 commented May 6, 2017

@oliviertassinari, hope it's not rude, but can u please bump material-ui version? (in order to get this fix, since it's pretty critical bug..)

Thanks

@oliviertassinari
Copy link
Member

@jony89 We try to release every two weeks. You gonna have to wait a bit or patch it locally.

@jony89
Copy link
Contributor

jony89 commented May 6, 2017

@oliviertassinari although there is a critical bug? is there a guide how to patch it locally or it's just one line of build?

sorry for the not connected conversation..

@omarchehab98
Copy link
Author

@jony89

  • clone the master branch of material-ui locally using git
  • transpile the source code using npm run build
  • delete the contents of node_modules/material-ui that you want to patch locally
  • copy the contents of the build directory into node_modules/material-ui

@jony89
Copy link
Contributor

jony89 commented May 6, 2017

Tnx, just wanted to make sure that there is nothing special :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants