Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Fix isRtl behaviour directionInvariant approach #6760

Merged
merged 2 commits into from
May 3, 2017
Merged

[Slider] Fix isRtl behaviour directionInvariant approach #6760

merged 2 commits into from
May 3, 2017

Commits on May 3, 2017

  1. [Slider] Unit testing isRtl behaviour 

    Direction invariant approach to #6736. As suggested by @oliviertassinari on #6744.
    @omarchehab98
    omarchehab98 committed May 3, 2017
    Configuration menu
    Copy the full SHA
    560289c View commit details
    Browse the repository at this point in the history

  2. [Slider] directionInvariant, transformed axis based on isRtl 

    Closes #6736. Direction invariant approach as suggested by @oliviertassinari on #6744. To access the `axis` prop of the `Slider` make sure to use `calculateAxis`.
    @omarchehab98
    omarchehab98 committed May 3, 2017
    Configuration menu
    Copy the full SHA
    f9ac963 View commit details
    Browse the repository at this point in the history