Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MuiThemeProvider] Add support for creating it without default theme #6900

Closed
wants to merge 4 commits into from
Closed

[MuiThemeProvider] Add support for creating it without default theme #6900

wants to merge 4 commits into from

Conversation

SukantGujar
Copy link

@SukantGujar SukantGujar commented May 19, 2017 •
edited by oliviertassinari
Loading

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Closes #6877.

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 19, 2017
@SukantGujar SukantGujar mentioned this pull request May 19, 2017
Closed
@oliviertassinari
Copy link
Member

The logic looks good to me, now you just need to get the CI green 😄 .

@oliviertassinari oliviertassinari changed the title [MuiThemeProvider] Add support for creating MuiThemeProvider sans createDefaultTheme. [MuiThemeProvider] Add support for creating it without theme. May 19, 2017
@oliviertassinari oliviertassinari changed the title [MuiThemeProvider] Add support for creating it without theme. [MuiThemeProvider] Add support for creating it without default theme May 19, 2017
@muibot muibot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 19, 2017
@SukantGujar
Copy link
Author

Done, please approve.

@oliviertassinari
Copy link
Member

@SukantGujar Sorry, it needs to be rebased. There is a conflict.

@SukantGujar
Copy link
Author

If it needs to be done at my end, could you guide me? I haven't done this before with a PR. Thanks.

@SukantGujar
Copy link
Author

Found instructions here, will try.

@mbrookes
Copy link
Member

@SukantGujar Are you still stuck with the rebase?

@viotti viotti mentioned this pull request May 29, 2017
Merged
3 tasks
@SukantGujar
Copy link
Author

Nope, just busy with work at the moment, will get back to this soon as I can.

oliviertassinari pushed a commit that referenced this pull request May 30, 2017
@viotti @oliviertassinari
[MuiThemeProvider] muiThemeProviderFactory implemented (#6900) (#7000)
b99fcab
@SukantGujar SukantGujar deleted the next branch May 30, 2017 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Size optimization opportunity in MuiThemeProvider
4 participants
@SukantGujar @oliviertassinari @mbrookes @muibot