Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MuiThemeProvider] Add a muiThemeProviderFactory #7000

Merged
merged 1 commit into from May 30, 2017
Merged

[MuiThemeProvider] Add a muiThemeProviderFactory #7000

merged 1 commit into from May 30, 2017

Conversation

viotti
Copy link
Contributor

@viotti viotti commented May 29, 2017

I took the liberty of making the rebase of #6900 whilst preserving the core changes of 8ab5299. Hope you guys don't mind. The only conflict to solve was related to the theme leaving the child context of MuiThemeProvider. I also had to make a couple of adjustments to satisfy prettier.

  • PR has tests / docs demo, and is linted.

I ran npm run test, but the commit has no new test cases.

  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Closes #6900
Closes #6877

@oliviertassinari oliviertassinari changed the title [MuiThemeProvider] muiThemeProviderFactory implemented (#6900) [MuiThemeProvider] Add a muiThemeProviderFactory May 29, 2017
@oliviertassinari oliviertassinari merged commit b99fcab into mui:next May 30, 2017
@oliviertassinari
Copy link
Member

Thanks :)

@SukantGujar
Copy link

Thank you so much. I have been occupied by work over the last few weeks and couldn't get to this at all. Moments like this make one really appreciate the efforts OSS maintainers put into their work. Its so challenging to be able to balance between job and other commitments.

@oliviertassinari
Copy link
Member

@SukantGujar Simply raising that point was valuable, thanks 👍 .

@mbrookes
Copy link
Member

mbrookes commented May 30, 2017

7000th PR merged!

Edit: no - wait, that's wrong. PRs and issues share the same sequence. Oh well:

PR# 7000 merged!

@zannager zannager added the customization: theme Centered around the theming features label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customization: theme Centered around the theming features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size optimization opportunity in MuiThemeProvider
5 participants