[AutoComplete] Fix ghost clicks on new requests

[amangeot]

Fixes ghost clicks happening when touch tapping AutoComplete's menu items on iOS touch devices.

The ghost clicks could lead to unexpected navigation with items underneath the AutoComplete's menu items

[mbrookes]

@amangeot Your change is causing tests to fail. Could you take a look? Thanks!

[oliviertassinari]

What about exposing a property so it can be implemented on userspace. I'm worried about the side effects here?

[max-b]

I'm working on a similar pull request for #6938 and I'm wondering if you could be a little clearer what you mean here? Would you mean doing something like passing the event object to the exposed onNewRequest property?

[amangeot]

Yes it sounds better adding a onItemTouchTap(event). Maybe a onItemTouchTap(event, index, request) ?

I'll try to push an update as soon as I can

[oliviertassinari]

I feel like the best API would be the one already exposed by the Menu onItemTouchTap. basically: onItemTouchTap(event, child). What do you think? I would rather keep things a simple as possible.

Also, I'm wondering if a previously added event.preventDefault haven't introduced the regression discussed in #6891 (comment)

[max-b]

@oliviertassinari ah oh I think I see what you mean there. I'm not sure what kind of time @amangeot has, but I think I understand what you're saying and if I find a few minutes this weekend I might make a go of fixing this. Same for #6938

Would a good PR then also update the docs?

[jony89]

I'll just say what I said in #6891, ghost click events are clicks. if you want to prevent those then you should verify that you are preventing a click event.

The above check-in is preventing both click and touch events. I tried to solve both issues in #6891

[oliviertassinari]

I'm closing the pull request as has been inactive for some time. I believe that we do no longer have the issue on the next branch as we migrated away from react-tap-event-plugin.