Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListItem] Exposing onTouchTap API in order to address Issue #6938 #7105

Merged
merged 1 commit into from Jun 12, 2017

Conversation

max-b
Copy link

@max-b max-b commented Jun 11, 2017

Allows for the fixing of #6938

From the conversation on #6907 it was suggested that instead of just calling an event.preventDefault within the listItem, the onTouchTap API be exposed to the user. That way it can be handled as appropriate.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added PR: Review Accepted bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module! labels Jun 12, 2017
@oliviertassinari oliviertassinari merged commit fcac6da into mui:master Jun 12, 2017
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 12, 2017

@max-b Thanks. Could you update the issue with your fix? I think that we could close it then.

@max-b
Copy link
Author

max-b commented Jun 12, 2017

@oliviertassinari done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants