[GridList] Export through main index.js #9833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we update the |
remcohaszing
commented
Jan 11, 2018
src/index.js
Outdated
| @@ -32,7 +32,7 @@ export { default as Icon } from './Icon'; | |||
| export { default as IconButton } from './IconButton'; | |||
| export { default as Input, InputLabel, InputAdornment } from './Input'; | |||
| export { default as Grid } from './Grid'; | |||
| export { GridList, GridListTile, GridListTileBar } from './GridList'; | |||
| export { default as GridList, GridListTile, GridListTileBar } from './GridList'; | |||
There was a problem hiding this comment.
I agree this is actually nicer.
Perhaps named GridList export from GridList/index.* should also be removed.
There was a problem hiding this comment.
Yes, we should for consistency. Do you want to fix it? :)
oliviertassinari
changed the title
oliviertassinari
added
new feature
|
@remcohaszing Thanks for raising the issue and fixing it :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the one component I've found so far that wasn't exported this way.