Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GridList] Remove named export #9836

Merged
merged 2 commits into from Jan 11, 2018
Merged

[GridList] Remove named export #9836

merged 2 commits into from Jan 11, 2018

Conversation

remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Jan 11, 2018

GridList is already exported as default. For consistency the named
export has been removed.

As requested in #9833

Breaking change

-import { GridList, GridListTile, GridListTileBar } from 'material-ui/GridList';
+import GridList, { GridListTile, GridListTileBar } from 'material-ui/GridList';

GridList is already exported as default. For consistency the named
export has been removed.
@oliviertassinari oliviertassinari added breaking change component: image list This is the name of the generic UI component, not the React module! labels Jan 11, 2018
@oliviertassinari oliviertassinari merged commit 1510463 into mui:v1-beta Jan 11, 2018
@oliviertassinari oliviertassinari changed the title [GridList] remove named export [GridList] Remove named export Jan 11, 2018
@oliviertassinari
Copy link
Member

@remcohaszing Great job. Thank you!

@dupski
Copy link

dupski commented Jan 12, 2018

Just a minor thing, but personally I would find it much easier if everything was a named export and there were no default exports. Its not always clear which I should be using. At the top of one of my files I have

import Paper from 'material-ui/Paper';
import IconButton from 'material-ui/IconButton';
import { LinearProgress } from 'material-ui/Progress';
import Table, { TableHead, TableBody, TableRow, TableCell } from 'material-ui/Table';
import Typography from 'material-ui/Typography';

it would be much cleaner like this:

import { Paper } from 'material-ui/Paper';
import { IconButton } from 'material-ui/IconButton';
import { LinearProgress } from 'material-ui/Progress';
import { Table, TableHead, TableBody, TableRow, TableCell } from 'material-ui/Table';
import { Typography } from 'material-ui/Typography';

Just my 2c :)

@mbrookes
Copy link
Member

@dupski We plan to address that differently: #9532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: image list This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants