-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] Support RTL #230
Comments
Based on https://npm-stat.com/charts.html?package=jss&package=jss-RTL&from=2021-09-17&to=2022-09-17 RTL is 2% of the global market share. So it should probably be a low priority for the maintainers of this project. Now, I think that it's typically why we are open source: if the community could work on a fix, it would be great. From my experience adding RTL support, it has never been really hard nor added a lot of bundlesize overhead, it's more that it has an opportunity cost. |
@oliviertassinari This issue exists in version 5. Can it be be reopened to be fixed in v5? |
@alii-7 the issue is open, per its status on GitHub. |
Per the email from Amir Mohammad Tavakoli, the documentation appears to claim RTL support: https://material-ui.com/components/data-grid/localization/ |
@mbrookes True, it's referenced once in the header description. We can fix this, by being more explicit. |
This comment was marked as duplicate.
This comment was marked as duplicate.
After many hours of trying a lot of things to fix it, I found a workaround for making the headers work correct with the data table of DataGrid, I just modified the direction of 2 classes to be ltr (assuming that the whole project is wrapped with RTL, in my case with 'stylis' and RTL plugin, using MUI V5). root: {
'& .MuiDataGrid-columnsContainer': {
direction: 'ltr'
}
'& .MuiDataGrid-virtualScroller': {
direction: 'ltr',
}
} I hope it helps someone :) |
@LironShirazi This solution #230 (comment) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I have a simple workaround, you can check it out if it helps https://codesandbox.io/s/nice-frost-5vuf86?file=/demo.js. |
Hi @oliviertassinari |
Any update on this? |
Current Behavior 😯
right-to-left is not supported
Expected Behavior 🤔
right-to-left is supported
Steps to Reproduce 🕹
Steps:
Context 🔦
I think that we should wait for upvotes before taking on this task. It's not a frequent requirement.
Your Environment 🌎
The text was updated successfully, but these errors were encountered: