[DataGridPro] Fix column resizing in RTL mode #4989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
cherniavskii
added
the
component: data grid
m4theushw
approved these changes
May 30, 2022
| @@ -245,7 +259,7 @@ export const useGridColumnResize = ( | |||
| const doc = ownerDocument(apiRef.current.rootElementRef!.current); | |||
| doc.body.style.cursor = 'col-resize'; | |||
|
|
|||
| separatorSide.current = getSeparatorSide(event.currentTarget); | |||
| separatorSide.current = getSeparatorSide(event.currentTarget, theme.direction); | |||
There was a problem hiding this comment.
Now makes sense to rename this ref to something like expansionDirection, since it doesn't represent the side of the separator anymore.
There was a problem hiding this comment.
Hmm, good point. Since it's not always an expansion, maybe resizeDirection?
flaviendelangle
approved these changes
Jun 1, 2022
|
Wokring great! Thanks guys 👍 💯 |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jun 13, 2022
* flip column resizing logic in RTL mode * rename separatorSide to resizeDirection
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
* flip column resizing logic in RTL mode * rename separatorSide to resizeDirection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4954
A quick win for RTL users using DataGridPro.
Before: https://codesandbox.io/s/columnsizinggrid-material-demo-forked-vqu1sx
After: https://codesandbox.io/s/columnsizinggrid-material-demo-forked-y0we73