Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Remove headerHeight and rowHeight from state #5620

Closed
Tracked by #3287
joserodolfofreitas opened this issue Jul 26, 2022 · 2 comments · Fixed by #7199
Closed
Tracked by #3287

[data grid] Remove headerHeight and rowHeight from state #5620

joserodolfofreitas opened this issue Jul 26, 2022 · 2 comments · Fixed by #7199
Assignees
@DanailH
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience v6.x

Comments

@joserodolfofreitas
Copy link
Member

joserodolfofreitas commented Jul 26, 2022 •
edited
Loading

Summary

Should we remove headerHeight and rowHeight from state?

mui-x/packages/grid/x-data-grid/src/hooks/features/density/useGridDensity.tsx

Line 16 in b778028

// TODO v6: revise keeping headerHeight and rowHeight in state

TODO: Clarify what we want to do.

Motivation
@joserodolfofreitas joserodolfofreitas added breaking change component: data grid This is the name of the generic UI component, not the React module! v6.x dx Related to developers' experience labels Jul 26, 2022
@joserodolfofreitas joserodolfofreitas mentioned this issue Jul 26, 2022
Closed
41 tasks
@m4theushw
Copy link
Member

m4theushw commented Jul 26, 2022 •
edited
Loading

For headerHeight it is related to #602

@DanailH DanailH self-assigned this Nov 22, 2022
@m4theushw
Copy link
Member

Context: #3218 (comment)

@DanailH DanailH mentioned this issue Nov 23, 2022
Merged
@DanailH DanailH mentioned this issue Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanailH DanailH

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! dx Related to developers' experience v6.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Remove rowHeight and headerHeight from state DanailH/material-ui-x
3 participants
@joserodolfofreitas @DanailH @m4theushw