Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Fix LazyLoading demo crash #10621

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[DataGrid] Fix LazyLoading demo crash #10621

merged 1 commit into from
Oct 9, 2023

Conversation

MBilalShafi
Copy link
Member

@MBilalShafi MBilalShafi commented Oct 9, 2023 •
edited
Loading

Fixes #10047

A nasty one reported twice in material-ui repo and eight times in mui-x repo.

@MBilalShafi MBilalShafi added bug 🐛 Something doesn't work docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Oct 9, 2023
@MBilalShafi MBilalShafi changed the title [DataGrid] Fix LazyLoading demo crash [DataGrid] Fix LazyLoading demo crash Oct 9, 2023
@mui-bot
Copy link

mui-bot commented Oct 9, 2023

Deploy preview: https://deploy-preview-10621--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against f702e26

cherniavskii
cherniavskii approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this nasty issue!

@cherniavskii cherniavskii added feature: Row loading Related to the data grid Row loading features and removed docs Improvements or additions to the documentation labels Oct 9, 2023
@MBilalShafi MBilalShafi merged commit 3bffdd7 into mui:master Oct 9, 2023
23 checks passed
@MBilalShafi MBilalShafi deleted the fix-lazy-loading-grid-crash branch October 9, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@romgrk romgrk Awaiting requested review from romgrk

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row loading Related to the data grid Row loading features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] Demo LazyLoadingGrid crashes
3 participants
@MBilalShafi @mui-bot @cherniavskii