Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document charts composition #10710

Merged
merged 11 commits into from
Nov 28, 2023

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Oct 18, 2023

Fix #10350

The idea is to have a central page that explains the overall idea of chart composition.

Each specific point should be in the dedicated pages.

The new page preview

TODO

  • Add basic demo
  • self review writing

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Oct 18, 2023
@mui-bot
Copy link

mui-bot commented Oct 18, 2023

docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
Signed-off-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
@alexfauquette alexfauquette marked this pull request as ready for review October 26, 2023 10:32
@michelengelen michelengelen changed the base branch from master to next November 6, 2023 14:20
@alexfauquette alexfauquette changed the base branch from next to master November 6, 2023 15:29
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation improvement! 👍

docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/composition/composition.md Outdated Show resolved Hide resolved
docs/data/charts/overview/overview.md Outdated Show resolved Hide resolved
docs/data/charts/overview/overview.md Show resolved Hide resolved
@samuelsycamore
Copy link
Member

I reviewed this doc in that bigger PR that also includes it 😅 sorry for the mess!

@alexfauquette
Copy link
Member Author

I reviewed this doc in that bigger PR that also includes it 😅 sorry for the mess!

No worries, it's my fault, I mixed up with which PR needs a review

@alexfauquette alexfauquette merged commit a71da3e into mui:master Nov 28, 2023
17 checks passed
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Nov 29, 2023
alexfauquette added a commit that referenced this pull request Nov 30, 2023
Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Andrew Cherniavskii <andrew.cherniavskii@gmail.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Co-authored-by: Rom Grk <romgrk@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Matheus Lúcio <matheusluciox@gmail.com>
Co-authored-by: Andrew Cherniavskii <andrew@mui.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Lucas Hilgert <77863078+lhilgert9@users.noreply.github.com>
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
Co-authored-by: Jerry_wu <409187100@qq.com>
Co-authored-by: wuls <linsheng.wu@beantechs.com>
Co-authored-by: Vu Dao <vu.dao@unity3d.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Document how the component order impact the overlapping
4 participants