[data grid] onFilterModelChange fires with stale field value
#10711
Conversation
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
|
Deploy preview: https://deploy-preview-10711--material-ui-x.netlify.app/ |
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
Co-authored-by: jasmyneokudo <38866525+jasmyneokudo@users.noreply.github.com>
zannager
added
the
component: data grid
alexfauquette
changed the title
onFilterModelChange fires with stale field value
| @@ -183,11 +183,11 @@ describe('<DataGrid /> - Filter panel', () => { | |||
|
|
|||
| setColumnValue('slogan'); | |||
|
|
|||
| expect(getColumnValues(0)).to.deep.equal([]); | |||
| expect(getColumnValues(0)).to.deep.equal(['Nike', 'Adidas', 'Puma']); | |||
There was a problem hiding this comment.
Thanks for looking into it!
While the fix is quite simple, it changed the filtering behavior in some valid use cases - this is why you had to update a few unit tests for them to pass.
Instead of always resetting the filter value, did you consider other options?
For example, resetting the filter value only if the type of the filtered column changes.
What do you think?
|
Is there any updates here? Why you closed the PR? @gitstart This fix is important for me and was looking forward to see it. |
@burakkgunduzz the PR got closed due to some internal cleanups on our end. |
Description
Upon investigation, we discovered that this issue occurs when a user wants to filter a value in a String column and then tries to change the String Column to a Number column. When this happens, the program tries to parse the string value the user initially inputted in the Value Text field to a number value, because it's unable to do that, it clears out the value from the Text Field but the value still remains in the items object in the program.
The solution to this would be to reset the item value property when the user switches from one column to another.
Loom Video
closes #10489
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.