-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Change the input format of adapter.getYearRange
to be consistent with adapter.isWithinRange
#10978
Merged
flaviendelangle
merged 6 commits into
mui:next
from
flaviendelangle:getYearRange-signature
Nov 13, 2023
Merged
[pickers] Change the input format of adapter.getYearRange
to be consistent with adapter.isWithinRange
#10978
flaviendelangle
merged 6 commits into
mui:next
from
flaviendelangle:getYearRange-signature
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapter.getYearRange
to be consistent with adapter.isWithingRange
adapter.getYearRange
to be consistent with adapter.isWithinRange
Deploy preview: https://deploy-preview-10978--material-ui-x.netlify.app/ Updated pages: |
…stent with adapter.isWithingRange
715a7ec
to
9d60035
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
alexfauquette
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: pickers
This is the name of the generic UI component, not the React module!
v7.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10977
Changelog
Breaking changes
The
adapter.getYearRange
method used to accept two params and now accepts a tuple to be consistent with theadapter.isWithinRange
method: