Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Change the input format of adapter.getYearRange to be consistent with adapter.isWithinRange #10978

Merged
merged 6 commits into from
Nov 13, 2023

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Nov 9, 2023

Closes #10977

Changelog

Breaking changes

  • The adapter.getYearRange method used to accept two params and now accepts a tuple to be consistent with the adapter.isWithinRange method:

    - adapter.getYearRange(start, end);
    + adapter.getYearRange([start, end])

@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x labels Nov 9, 2023
@flaviendelangle flaviendelangle self-assigned this Nov 9, 2023
@flaviendelangle flaviendelangle changed the title [pickers] Change the input format of adapter.getYearRange to be consistent with adapter.isWithingRange [pickers] Change the input format of adapter.getYearRange to be consistent with adapter.isWithinRange Nov 9, 2023
@mui-bot
Copy link

mui-bot commented Nov 9, 2023

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 10, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 10, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@flaviendelangle flaviendelangle merged commit 5cc8789 into mui:next Nov 13, 2023
16 checks passed
@flaviendelangle flaviendelangle deleted the getYearRange-signature branch November 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] v7: Change the input format of adapter.getYearRange to be consistent with adapter.isWithinRange
3 participants