[docs] Add small formatting improvements to the licensing page #11178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11178--material-ui-x.netlify.app/ Updated pages: |
|
|
||
| The Pro version is available under a commercial license—visit [the Pricing page](https://mui.com/r/x-get-license/) for details. | ||
| Exclusive features are marked with the <span class="plan-pro" aria-label="MUI X Pro plan icon"></span> icon throughout the documentation. |
There was a problem hiding this comment.
beyond the scope of this PR but we should track down all of these lil plan spans and give them all aria labels where they're missing
There was a problem hiding this comment.
I checked out these spans in the navigation bar and they all appear to have a title that the screen reader picks up as an ARIA label, but I suspect there may be others scattered around in the Markdown that don't have them.
There was a problem hiding this comment.
For sure, yeah! I'm just now getting deeper into the X docs space, so definitely looking forward to doing it!
samuelsycamore
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on mui/material-ui#39832, I noticed a few relatively quick improvement opportunities for the MUI X docs! This one adds in just some minor copywriting and formatting tweaks to make the page more consistent:
👉 https://deploy-preview-11178--material-ui-x.netlify.app/x/introduction/licensing/