[TreeView] Throw an error when two items have the same id #11715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: tree view
flaviendelangle
changed the title
flaviendelangle
commented
Jan 17, 2024
| const { render } = createRenderer(); | ||
|
|
||
| it('should throw an error when two items have the same ID (items prop approach)', function test() { | ||
| // TODO is this fixed? |
There was a problem hiding this comment.
The grid could not run similar tests with karma, I tried a little but did not want to invest to much time on it
|
Deploy preview: https://deploy-preview-11715--material-ui-x.netlify.app/ |
packages/x-tree-view/src/internals/plugins/useTreeViewNodes/useTreeViewNodes.test.tsx
Show resolved
Hide resolved
michelengelen
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10230
Not required before beta, nothing breaking here 馃憤